[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 08/14] vga: Simplify vga_draw_blank() a bit
From: |
Benjamin Herrenschmidt |
Subject: |
[Qemu-devel] [RFC 08/14] vga: Simplify vga_draw_blank() a bit |
Date: |
Tue, 24 Jun 2014 09:11:02 +1000 |
The test for surface_bits_per_pixel() isn't necessary anymore,
the 8bpp case never happens.
Signed-off-by: Benjamin Herrenschmidt <address@hidden>
---
hw/display/vga.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/hw/display/vga.c b/hw/display/vga.c
index 70405e6..3b2cca5 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -1639,7 +1639,7 @@ static void vga_draw_graphic(VGACommonState *s, int
full_update)
static void vga_draw_blank(VGACommonState *s, int full_update)
{
DisplaySurface *surface = qemu_console_surface(s->con);
- int i, w, val;
+ int i, w;
uint8_t *d;
if (!full_update)
@@ -1647,15 +1647,10 @@ static void vga_draw_blank(VGACommonState *s, int
full_update)
if (s->last_scr_width <= 0 || s->last_scr_height <= 0)
return;
- if (surface_bits_per_pixel(surface) == 8) {
- val = rgb_to_pixel32(0, 0, 0);
- } else {
- val = 0;
- }
w = s->last_scr_width * surface_bytes_per_pixel(surface);
d = surface_data(surface);
for(i = 0; i < s->last_scr_height; i++) {
- memset(d, val, w);
+ memset(d, 0, w);
d += surface_stride(surface);
}
dpy_gfx_update(s->con, 0, 0,
--
1.9.1
- [Qemu-devel] [RFC 00/14] VGA cleanups and endian control, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 09/14] cirrus: Remove non-32bpp cursor drawing, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 01/14] vga: Create direct sufaces for depth 24 too, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 04/14] vga: Remove remainder of old conversion cruft, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 06/14] vga: 15 and 16bpp draw functions are "swapping" only, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 03/14] vga: Start cutting out non-32bpp conversion support, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 08/14] vga: Simplify vga_draw_blank() a bit,
Benjamin Herrenschmidt <=
- [Qemu-devel] [RFC 10/14] vga: Remove some "should be done in BIOS" comments, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 07/14] vga: Remove rgb_to_pixel indirection, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 13/14] vga: Add endian control register, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 12/14] vga: Rename vga_template.h to vga-helpers.h, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 05/14] vga: Remove unused vga_draw_line24() and vga_draw_line32(), Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 11/14] vga: Make fb endian a common state variable, Benjamin Herrenschmidt, 2014/06/23