[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 11/14] vga: Make fb endian a common state variable
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [RFC 11/14] vga: Make fb endian a common state variable |
Date: |
Tue, 24 Jun 2014 09:44:46 +1000 |
On Tue, 2014-06-24 at 00:24 +0100, Peter Maydell wrote:
> On 24 June 2014 00:11, Benjamin Herrenschmidt <address@hidden> wrote:
> > And initialize it based on target endian
> > @@ -155,6 +155,7 @@ typedef struct VGACommonState {
> > const GraphicHwOps *hw_ops;
> > bool full_update_text;
> > bool full_update_gfx;
> > + bool big_endian_fb;
>
> Don't we need to migrate this new state somehow?
Only when it can change, which is done in patch 13
This patch (11) just moves it around to the state but its value is still
fixed at this point in the series.
Cheers,
Ben.
- Re: [Qemu-devel] [RFC 10/14] vga: Remove some "should be done in BIOS" comments, (continued)
- [Qemu-devel] [RFC 07/14] vga: Remove rgb_to_pixel indirection, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 13/14] vga: Add endian control register, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 12/14] vga: Rename vga_template.h to vga-helpers.h, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 05/14] vga: Remove unused vga_draw_line24() and vga_draw_line32(), Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 11/14] vga: Make fb endian a common state variable, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 14/14] ppc/spapr/vga: Switch VGA endian on H_SET_MODE, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 02/14] ui: Remove unused QEMU_BIG_ENDIAN_FLAG, Benjamin Herrenschmidt, 2014/06/23
- Re: [Qemu-devel] [RFC 00/14] VGA cleanups and endian control, Gerd Hoffmann, 2014/06/30