|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 0/3] target-sparc: fixed unused function warnings |
Date: | Mon, 23 Jun 2014 21:24:30 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/23/2014 04:01 PM, Peter Maydell wrote: > These patchsets fix clang 3.4 warnings about unused static inline > functions (clang now warns about these if they're defined in a > .c file but then not used; gcc doesn't). The first patch just > removes two totally unused functions; the second two patches > use ifdeffery to avoid defining the functions in non-TARGET_SPARC64 > builds. I think I would be happier if you changed the functions to not be marked as "inline". I think that there's a large body of code that marks things inline exactly to prevent unused warnings with gcc. If we're going to play with the ifdeffery, we might as well just let any compiler warn if its unused. r~
[Prev in Thread] | Current Thread | [Next in Thread] |