qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2.1 34/36] qemu-char: make writes thread-safe


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2.1 34/36] qemu-char: make writes thread-safe
Date: Wed, 25 Jun 2014 09:03:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

Il 25/06/2014 08:06, Stefan Weil ha scritto:
Am 18.06.2014 08:43, schrieb Paolo Bonzini:
This will let threads other than the I/O thread raise QMP events.

GIOChannel is thread-safe, and send and receive state is usually
well-separated.  The only driver that requires some care is the
pty driver, where some of the state is shared by the read and write
sides.  That state is protected with the chr_write_lock too.

Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
 include/sysemu/char.h | 11 ++++++----
 qemu-char.c           | 58 ++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 53 insertions(+), 16 deletions(-)


Latest QEMU is broken for w64. This command no longer starts the GTK gui:

wine64 x86_64-softmmu/qemu-system-x86_64 -L pc-bios

Wine reports a dead lock:

err:ntdll:RtlpWaitForCriticalSection section 0x964f0 "?" wait timed out
in thread 0009, blocked by 0000, retrying (60 sec)

Actually this message is more likely to be a missing qemu_mutex_init, and in fact that's what it is. I'm sorry, I'll send a patch right away.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]