Re: [Qemu-devel] [PATCH 4/4] [RFC] Eliminate PC-specific compat_props

[Michael S. Tsirkin]

On Wed, Jun 25, 2014 at 10:25:12AM -0300, Eduardo Habkost wrote:
> On Wed, Jun 25, 2014 at 07:55:53AM +0300, Michael S. Tsirkin wrote:
> [...]
> > 
> > As far as I can tell this will break hpet,
> > because you set it incorrectly for PIIX
> > 
> >   #define QEMU_COMPAT_1_7 \
> >  @@ -179,6 +197,16 @@ struct MachineState {
> >           .driver   = TYPE_USB_DEVICE,\
> >           .property = "msos-desc",\
> >           .value    = "no",\
> >  +    },\
> >  +    {\
> >  +        .driver   = "PIIX4_PM",\
> >  +        .property = "acpi-pci-hotplug-with-bridge-support",\
> >  +        .value    = "off",\
> >  +    }, \
> >  +    {\
> >  +        .driver   = "hpet",\
> >  +        .property = HPET_INTCAP,\
> >  +        .value    = stringify(4),\
> >       }
> >   
> > 
> > AFAIK above is appropriate for Q35 but not PIIX.
> > 
> > See commit log for
> > commit 7a10ef51c2397ac4323bc786af02c58b413b5cd2
> >     hpet: enable to entitle more irq pins for hpet
> 
> I assume this was explained in the v2 commit message, and there was no
> bug here, right?
> 
> -- 
> Eduardo



yes.