Re: [Qemu-devel] [RFC v2 1/2] arm: Add the cortex-a9 CPU to the a9mpcore device

[Alistair Francis]

Ping^2

On Mon, Jun 23, 2014 at 11:38 AM, Alistair Francis
<address@hidden> wrote:
> Ping
>
> On Tue, Jun 17, 2014 at 3:57 PM, Alistair Francis
> <address@hidden> wrote:
>> Add Stefan Hajnoczi as it relies on his work
>> (http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg06489.html)
>>
>> On Tue, Jun 17, 2014 at 2:18 PM, Alistair Francis
>> <address@hidden> wrote:
>>> This patch adds the Cortex-A9 ARM CPU to the A9MPCore.
>>>
>>> The CPU is only created if the num-cpu property is set.
>>>
>>> This patch relies on Stefan Hajnoczi's v3 'virtio-blk:
>>> use alias properties in transport devices' patch. This is
>>> used to pass the CPU properties through to the mpcore.
>>>
>>> This patch allows the midr and reset-cbar properties to be set
>>>
>>> Signed-off-by: Alistair Francis <address@hidden>
>>> ---
>>> V2: - Small fixes thanks to Peter Crosthwaite
>>>     - Properties are now passed through
>>>     - CPUs are no longer inited in the realize
>>>       function, instead it uses a property listening function
>>>         - Thanks to Maydell, Crosthwaite and Andreas
>>> V1: First Release
>>>
>>>  hw/cpu/a9mpcore.c         |   62 
>>> ++++++++++++++++++++++++++++++++++++++++++++-
>>>  include/hw/cpu/a9mpcore.h |    3 ++
>>>  2 files changed, 64 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c
>>> index c09358c..3d22b86 100644
>>> --- a/hw/cpu/a9mpcore.c
>>> +++ b/hw/cpu/a9mpcore.c
>>> @@ -17,10 +17,54 @@ static void a9mp_priv_set_irq(void *opaque, int irq, 
>>> int level)
>>>      qemu_set_irq(qdev_get_gpio_in(DEVICE(&s->gic), irq), level);
>>>  }
>>>
>>> +static void a9mpcore_init_cpus(Object *obj, Visitor *v,
>>> +                               void *opaque, const char *name,
>>> +                               Error **errp)
>>> +{
>>> +    A9MPPrivState *s = A9MPCORE_PRIV(obj);
>>> +    ObjectClass *cpu_oc;
>>> +    Error *err = NULL;
>>> +    int i;
>>> +    int64_t value;
>>> +
>>> +    visit_type_int(v, &value, name, &err);
>>> +    if (err) {
>>> +        error_propagate(errp, err);
>>> +        return;
>>> +    }
>>> +    s->num_cpu = value;
>>> +
>>> +    s->cpu = g_new0(ARMCPU, s->num_cpu);
>>> +    cpu_oc = cpu_class_by_name(TYPE_ARM_CPU, "cortex-a9");
>>> +
>>> +    for (i = 0; i < s->num_cpu; i++) {
>>> +        object_initialize(&s->cpu[i], sizeof(*s->cpu),
>>> +                          object_class_get_name(cpu_oc));
>>> +
>>> +        object_property_add_alias(obj, "midr", OBJECT(&s->cpu[i]),
>>> +                                  "midr", NULL);
>>> +        object_property_add_alias(obj, "reset-cbar", OBJECT(&s->cpu[i]),
>>> +                                  "reset-cbar", NULL);
>>> +        /* This fails to pass through thte reset-cbar property
>>> +         * The qdev_alias_all_properties() also fails with multiple CPUs
>>> +         * Hence the code above is used instead
>>> +         * qdev_alias_all_properties(DEVICE(&s->cpu[i]), obj);
>>> +         */
>>> +    }
>>> +}
>>> +
>>>  static void a9mp_priv_initfn(Object *obj)
>>>  {
>>>      A9MPPrivState *s = A9MPCORE_PRIV(obj);
>>>
>>> +    /* Set up the CPU to be initiated */
>>> +    object_property_add(obj, "num-cpu", "int",
>>> +                        NULL, a9mpcore_init_cpus,
>>> +                        NULL, NULL, NULL);
>>> +    /* Use this as the default */
>>> +    s->cpu = NULL;
>>> +    s->num_cpu = 1;
>>> +
>>>      memory_region_init(&s->container, obj, "a9mp-priv-container", 0x2000);
>>>      sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->container);
>>>
>>> @@ -50,6 +94,17 @@ static void a9mp_priv_realize(DeviceState *dev, Error 
>>> **errp)
>>>      Error *err = NULL;
>>>      int i;
>>>
>>> +    if (s->cpu) {
>>> +        for (i = 0; i < s->num_cpu; i++) {
>>> +            object_property_set_bool(OBJECT(&s->cpu[i]), true,
>>> +                                     "realized", &err);
>>> +            if (err) {
>>> +                error_propagate(errp, err);
>>> +                return;
>>> +            }
>>> +        }
>>> +    }
>>> +
>>>      scudev = DEVICE(&s->scu);
>>>      qdev_prop_set_uint32(scudev, "num-cpu", s->num_cpu);
>>>      object_property_set_bool(OBJECT(&s->scu), true, "realized", &err);
>>> @@ -75,6 +130,12 @@ static void a9mp_priv_realize(DeviceState *dev, Error 
>>> **errp)
>>>      /* Pass through inbound GPIO lines to the GIC */
>>>      qdev_init_gpio_in(dev, a9mp_priv_set_irq, s->num_irq - 32);
>>>
>>> +    /* Connect the GIC to the first CPU */
>>> +    if (s->cpu) {
>>> +        sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0,
>>> +                           qdev_get_gpio_in(DEVICE(s->cpu), ARM_CPU_IRQ));
>>> +    }
>>> +
>>>      gtimerdev = DEVICE(&s->gtimer);
>>>      qdev_prop_set_uint32(gtimerdev, "num-cpu", s->num_cpu);
>>>      object_property_set_bool(OBJECT(&s->gtimer), true, "realized", &err);
>>> @@ -144,7 +205,6 @@ static void a9mp_priv_realize(DeviceState *dev, Error 
>>> **errp)
>>>  }
>>>
>>>  static Property a9mp_priv_properties[] = {
>>> -    DEFINE_PROP_UINT32("num-cpu", A9MPPrivState, num_cpu, 1),
>>>      /* The Cortex-A9MP may have anything from 0 to 224 external interrupt
>>>       * IRQ lines (with another 32 internal). We default to 64+32, which
>>>       * is the number provided by the Cortex-A9MP test chip in the
>>> diff --git a/include/hw/cpu/a9mpcore.h b/include/hw/cpu/a9mpcore.h
>>> index 5d67ca2..2e57116 100644
>>> --- a/include/hw/cpu/a9mpcore.h
>>> +++ b/include/hw/cpu/a9mpcore.h
>>> @@ -15,6 +15,7 @@
>>>  #include "hw/misc/a9scu.h"
>>>  #include "hw/timer/arm_mptimer.h"
>>>  #include "hw/timer/a9gtimer.h"
>>> +#include "qapi/visitor.h"
>>>
>>>  #define TYPE_A9MPCORE_PRIV "a9mpcore_priv"
>>>  #define A9MPCORE_PRIV(obj) \
>>> @@ -29,6 +30,8 @@ typedef struct A9MPPrivState {
>>>      MemoryRegion container;
>>>      uint32_t num_irq;
>>>
>>> +    ARMCPU *cpu;
>>> +
>>>      A9SCUState scu;
>>>      GICState gic;
>>>      A9GTimerState gtimer;
>>> --
>>> 1.7.1
>>>