[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines |
|
Date: |
Thu, 26 Jun 2014 05:52:45 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/26/2014 12:13 AM, Hu Tao wrote:
> We already have ROUND_UP but there are similar macros and ROUND_UP-like
> lines all around, replace them with ROUND_UP and clean up similar macros.
Not a review (yet), but a question - how did you find lines to convert?
Is there a particular grep pattern you looked for, or a Coccinelle
script, or ...? I ask because it would be nice information in the commit
message, so that the actual review can also look to see if you missed
any instances that could use the conversion.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature