[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2.1 23/36] qapi event: convert other BLOCK_JOB e
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 2.1 23/36] qapi event: convert other BLOCK_JOB events |
Date: |
Thu, 26 Jun 2014 16:08:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> From: Wenchao Xia <address@hidden>
>
> Since BLOCK_JOB_COMPLETED, BLOCK_JOB_CANCELLED, BLOCK_JOB_READY are
> related, convert them in one patch. The block_job_event_* functions
> are used to keep encapsulation of BlockJob structure.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
This broke tests/qemu-iotests/040. Apparently, the BLOCK_JOB_READY
event changed from
{'timestamp': {'seconds': 1403791120, 'microseconds': 539716},
'data': {'device': 'drive0',
'type': 'commit',
'speed': 0,
'len': 1048576,
'offset': 1048576},
'event': 'BLOCK_JOB_READY'}
to just
{'timestamp': {'seconds': 1403790920, 'microseconds': 123232},
'data': {'device': 'drive0'},
'event': 'BLOCK_JOB_READY'}
breaking qemu-iotests/040's tests of data/type and data/len.
Documentation of BLOCK_JOB_READY shows only data/device, before and
after this patch.
Suggests that
* Before this patch, code disagreed with docs, and qemu-iotests/040
matched the code.
* After this patch, code matches docs, and qemu-iotests/040 matches
neither.
Please advise.
- [Qemu-devel] [PATCH 2.1 13/36] qapi event: convert RESUME, (continued)
- [Qemu-devel] [PATCH 2.1 13/36] qapi event: convert RESUME, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 17/36] qapi event: convert RTC_CHANGE, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 18/36] qapi event: convert WATCHDOG, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 19/36] qapi event: convert DEVICE_DELETED, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 20/36] qapi event: convert DEVICE_TRAY_MOVED, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 22/36] qapi event: convert BLOCK_IMAGE_CORRUPTED, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 23/36] qapi event: convert other BLOCK_JOB events, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Paolo Bonzini, 2014/06/18
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Markus Armbruster, 2014/06/26
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Paolo Bonzini, 2014/06/26
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Luiz Capitulino, 2014/06/26
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Markus Armbruster, 2014/06/26
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Luiz Capitulino, 2014/06/26
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Markus Armbruster, 2014/06/27
[Qemu-devel] [PATCH 2.1 24/36] qapi event: convert NIC_RX_FILTER_CHANGED, Paolo Bonzini, 2014/06/18