Re: [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain drivers

[Max Reitz]

On 23.06.2014 10:35, Stefan Hajnoczi wrote:
> On Wed, Jun 18, 2014 at 12:14:08AM +0200, Max Reitz wrote:
> > For some protocol block drivers, the "filename" attribute in their BDSs
> > is unset due to bdrv_file_open() removing it from the options QDict
> > before bdrv_open_common() is able to copy it into the BDS. Fix this by
> > not removing it until until bdrv_open_common() has indeed copied it.
> >
> >
> > Max Reitz (2):
> >    block: Do not prematurely remove "filename"
> >    iotests: Add test for set "filename" for NBD
> >
> >   block.c                    | 12 ++++++--
> >   tests/qemu-iotests/097     | 72 ++++++++++++++++++++++++++++++++++++++++++++++
> >   tests/qemu-iotests/097.out | 13 +++++++++
> >   tests/qemu-iotests/group   |  1 +
> >   4 files changed, 95 insertions(+), 3 deletions(-)
> >   create mode 100755 tests/qemu-iotests/097
> >   create mode 100644 tests/qemu-iotests/097.out
> Please check qemu-iotests 051.  Dropping from block queue for now.

Thanks for catching this. The problem was me always removing the 
"filename" entry from the QDict if the driver could not handle it; 
however, to maintain the current behavior, it should only be removed if 
it has been parsed before. I'll send a v2.

Max