qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support


From: Christian Borntraeger
Subject: Re: [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support
Date: Fri, 27 Jun 2014 09:53:19 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

On 26/06/14 16:42, Alexander Graf wrote:
> 
> On 26.06.14 16:29, Jens Freimann wrote:
>> Conny, Alex, Christian,
>>
>> here are some fixes for the s390-ccw bios. It's a mixture of
>> additional features (DASD IPL support for different formats)
>> and cleanups.
> 
> From a quick glimpse it looks quite clean and straight forward, but I'd like 
> to make sure we get rid completely of the static sector size assumption.

Should be. I guess s/SECTOR_SIZE/MAX_SECTOR_SIZE/g would be ok for you then?
> 
> Also, are we guaranteed that virtio always uses 512 byte block size? Or was 
> that just an internal API thing?

The virtio-blk API always talks in 512 byte sectors, no matter the block size.

Overall this is a nice improvement of the boot code - if possible I would like 
to see that in 2.1.

Conny, can you carry that in your tree (with s/SECTOR_SIZE/MAX_SECTOR_SIZE/g)?

Acked-by: Christian Borntraeger <address@hidden>

for the series.


Christian




reply via email to

[Prev in Thread] Current Thread [Next in Thread]