[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support |
Date: |
Fri, 27 Jun 2014 11:27:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 27/06/14 11:05, Alexander Graf wrote:
>
>
>> Am 27.06.2014 um 09:53 schrieb Christian Borntraeger <address@hidden>:
>>
>>> On 26/06/14 16:42, Alexander Graf wrote:
>>>
>>>> On 26.06.14 16:29, Jens Freimann wrote:
>>>> Conny, Alex, Christian,
>>>>
>>>> here are some fixes for the s390-ccw bios. It's a mixture of
>>>> additional features (DASD IPL support for different formats)
>>>> and cleanups.
>>>
>>> From a quick glimpse it looks quite clean and straight forward, but I'd
>>> like to make sure we get rid completely of the static sector size
>>> assumption.
>>
>> Should be. I guess s/SECTOR_SIZE/MAX_SECTOR_SIZE/g would be ok for you then?
>
> I'm not 100% convinced that we're safe on all users of SECTOR_SIZE. So please
> make sure to replace the occasions manually and audit every single one.
Yes, a mindless sed, would also replace VIRTIO_SECTOR_SIZE with
VIRTIO_MAX_SECTOR_SIZE.
Fortunately there are only 3 place in bootmap.c. Should be simple enough to
review.
>
> Alex
>
>>>
>>> Also, are we guaranteed that virtio always uses 512 byte block size? Or was
>>> that just an internal API thing?
>>
>> The virtio-blk API always talks in 512 byte sectors, no matter the block
>> size.
>>
>> Overall this is a nice improvement of the boot code - if possible I would
>> like to see that in 2.1.
>>
>> Conny, can you carry that in your tree (with
>> s/SECTOR_SIZE/MAX_SECTOR_SIZE/g)?
>>
>> Acked-by: Christian Borntraeger <address@hidden>
>>
>> for the series.
>>
>>
>> Christian
>>
>
- [Qemu-devel] [PATCH 04/10] pc-bios/s390-ccw: add some utility code, (continued)
- [Qemu-devel] [PATCH 04/10] pc-bios/s390-ccw: add some utility code, Jens Freimann, 2014/06/26
- [Qemu-devel] [PATCH 05/10] pc-bios/s390-ccw: Unify error handling, Jens Freimann, 2014/06/26
- [Qemu-devel] [PATCH 09/10] pc-bios/s390-ccw: IPL from LDL/CMS-formatted ECKD DASD, Jens Freimann, 2014/06/26
- [Qemu-devel] [PATCH 10/10] pc-bios/s390-ccw: update binary, Jens Freimann, 2014/06/26
- [Qemu-devel] [PATCH 07/10] pc-bios/s390-ccw: factor out ipl code, Jens Freimann, 2014/06/26
- [Qemu-devel] [PATCH 06/10] pc-bios/s390-ccw: Add fill_hex_val func to provide better msgs, Jens Freimann, 2014/06/26
- [Qemu-devel] [PATCH 08/10] pc-bios/s390-ccw: IPL from CDL-formatted ECKD DASD, Jens Freimann, 2014/06/26
- Re: [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support, Alexander Graf, 2014/06/26