[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hw/net/eepro100: Implement read-only bits in
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] hw/net/eepro100: Implement read-only bits in MDI registers |
|
Date: |
Fri, 27 Jun 2014 12:25:22 +0200 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jun 09, 2014 at 04:03:08PM +0100, Peter Maydell wrote:
> Although we defined an eepro100_mdi_mask[] array indicating which bits
> in the registers are read-only, we weren't actually doing anything with
> it. Make the MDI register-write code use it rather than manually making
> register 1 read-only and leaving the rest as reads-as-written. (The
> special-case handling of register 0 remains as before since its mask is
> all-zeros and the special casing happens before we apply the masking.)
>
> Signed-off-by: Peter Maydell <address@hidden>
> Message-id: address@hidden
> ---
> No code change, but I fixed the errors in the commit message.
>
> hw/net/eepro100.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
pgpBo2rxY4qqc.pgp
Description: PGP signature