[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg/ppc: Fix failure in tcg_out_mem_long
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] tcg/ppc: Fix failure in tcg_out_mem_long |
Date: |
Fri, 27 Jun 2014 13:45:06 +0100 |
On 27 June 2014 05:26, Richard Henderson <address@hidden> wrote:
> With rt != r0 on loads, we use rt for scratch. If we need an index
> register different from base, we can't use rt, but r0 is usable.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> This ought to fix the problem that Greg reported.
>
> That we need to use --enable-debug-tcg to see the assert, and that I
> didn't previously do testing with that is disappointing. I'm thinking
> that we ought to do something like gcc wrt --enable-checking=release
> vs development, so that we can't do normal development withing these
> asserts enabled. More on that later...
>
>
> r~
> ---
> tcg/ppc/tcg-target.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Thanks; applied to master as a build fix.
-- PMM