Re: [Qemu-devel] [PATCH 3/3] numa: Reject configuration if not all node IDs are present

[Eduardo Habkost]

On Fri, Jun 27, 2014 at 11:33:59AM +0800, Hu Tao wrote:
> On Thu, Jun 26, 2014 at 06:33:20PM -0300, Eduardo Habkost wrote:
> > We don't support sparse NUMA node IDs yet, so this changes QEMU to
> > reject configs where not all nodes are present.
> > 
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> >  numa.c | 17 ++++++++++++++++-
> >  1 file changed, 16 insertions(+), 1 deletion(-)
> > 
> > diff --git a/numa.c b/numa.c
> > index e93407a..96fe5dd 100644
> > --- a/numa.c
> > +++ b/numa.c
> > @@ -160,9 +160,24 @@ error:
> >  
> >  void set_numa_nodes(void)
> >  {
> > +    int i;
> > +
> > +    assert(max_numa_nodeid <= MAX_NODES);
> > +
> > +    /* No support for sparse NUMA node IDs yet: */
> > +    for (i = max_numa_nodeid - 1; i >= 0; i--) {
> > +        /* Report large node IDs first, to make mistakes easier to spot */
> > +        if (!numa_info[i].present) {
> > +            error_report("numa: Node ID missing: %d", i);
> > +            exit(1);
> 
> This reports only one missing node id. Dont' we report all missing ids?

I considered that, but then a simple user mistake could make QEMU spit
more than 100 lines of error messages.

I expect this error code to go away soon, anyway (as soon as we
implement sparse node ID support).

-- 
Eduardo