[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq |
Date: |
Fri, 27 Jun 2014 18:19:05 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 27.06.2014 um 15:29 hat Stefan Hajnoczi geschrieben:
> On Wed, Jun 11, 2014 at 12:11:41PM +0800, Fam Zheng wrote:
> > This unifies the request structure used by dataplane and non-dataplane code,
> > while dropping unnessary fields for bounce buffer and read flag.
> >
> > v4: Address Stefan's comments as below, and add Paolo's rev-by lines to
> > others.
> >
> > [01/09] virtio-blk: Move VirtIOBlockReq to header
> >
> > Include "block/block.h".
> >
> > [02/09] virtio-blk: Convert VirtIOBlockReq.elem to pointer
> >
> > Use g_slice_new0 for req as well.
> >
> > [06/09] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr
> >
> > Check guest input, don't assert.
> >
> > [09/09] virtio-blk: Fix and clean up the in_sg and out_sg check
> >
> > Use error_report + exit.
> >
> > Fam Zheng (9):
> > virtio-blk: Move VirtIOBlockReq to header
> > virtio-blk: Convert VirtIOBlockReq.elem to pointer
> > virtio-blk: Drop bounce buffer from dataplane code
> > virtio-blk: Drop VirtIOBlockRequest.read
> > virtio-blk: Replace VirtIOBlockRequest with VirtIOBlockReq
> > virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr
> > virtio-blk: Convert VirtIOBlockReq.out to structrue
> > virtio-blk: Fill in VirtIOBlockReq.out in dataplane code
> > virtio-blk: Fix and clean up the in_sg and out_sg check
> >
> > hw/block/dataplane/virtio-blk.c | 169
> > ++++++++++++++--------------------------
> > hw/block/virtio-blk.c | 117 +++++++++++++++-------------
> > include/hw/virtio/virtio-blk.h | 11 +++
> > 3 files changed, 132 insertions(+), 165 deletions(-)
> >
> > --
> > 2.0.0
> >
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
Thanks, applied all to the block branch.
Kevin
pgpnEUpBHXKBa.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v4 1/9] virtio-blk: Move VirtIOBlockReq to header, (continued)
- [Qemu-devel] [PATCH v4 1/9] virtio-blk: Move VirtIOBlockReq to header, Fam Zheng, 2014/06/11
- [Qemu-devel] [PATCH v4 2/9] virtio-blk: Convert VirtIOBlockReq.elem to pointer, Fam Zheng, 2014/06/11
- [Qemu-devel] [PATCH v4 4/9] virtio-blk: Drop VirtIOBlockRequest.read, Fam Zheng, 2014/06/11
- [Qemu-devel] [PATCH v4 3/9] virtio-blk: Drop bounce buffer from dataplane code, Fam Zheng, 2014/06/11
- [Qemu-devel] [PATCH v4 5/9] virtio-blk: Replace VirtIOBlockRequest with VirtIOBlockReq, Fam Zheng, 2014/06/11
- [Qemu-devel] [PATCH v4 6/9] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr, Fam Zheng, 2014/06/11
- [Qemu-devel] [PATCH v4 7/9] virtio-blk: Convert VirtIOBlockReq.out to structrue, Fam Zheng, 2014/06/11
- [Qemu-devel] [PATCH v4 8/9] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code, Fam Zheng, 2014/06/11
- [Qemu-devel] [PATCH v4 9/9] virtio-blk: Fix and clean up the in_sg and out_sg check, Fam Zheng, 2014/06/11
- Re: [Qemu-devel] [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq, Stefan Hajnoczi, 2014/06/27
- Re: [Qemu-devel] [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq,
Kevin Wolf <=