qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind
Date: Mon, 30 Jun 2014 12:31:54 +0100

On 30 June 2014 11:57, Gerd Hoffmann <address@hidden> wrote:
> IIRC "wait for client to connect" is a blocking accept() call.  Which
> you certainly don't want do in a qmp command handler.  So if we switch
> over chardevs created via -chardev to use the qmp init code path too we
> need some hackery to make '-chardev socket,wait,...' work without
> introducing a blocking qmp command I suspect ...

We already have blocking code paths in qmp_chardev_open_socket():
for the non-listening case we call socket_connect() with a NULL callback
argument, which will result in our calling connect() in blocking mode.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]