qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 2/3] linux-aio: implement io plug and unplug


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v1 2/3] linux-aio: implement io plug and unplug
Date: Tue, 01 Jul 2014 08:16:09 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

Il 01/07/2014 03:05, Ming Lei ha scritto:
> Busy waiting is not acceptable here (it can be unbounded if, for example, an
> NFS server is on the other side of a network partition). You have to add a
> bottom half to qemu_laio_state that calls ioq_submit, and schedule it after
> calling io_getevents.
>
> If the bottom half is already scheduled and the queue is full, I guess
> there's no other choice than returning -EAGAIN from ioq_enqueue and
> ultimately to the guest.
That is a bit complicated, as you mentioned it is close to
2.1 release, could we just keep it simple to return failure to guest
after retrying several times? Actually, previous dataplane handles
it by exit(-1), which is unfriendly absolutely.

Indeed, I'd say do not even bother retrying several times. :)

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]