[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin |
|
Date: |
Tue, 1 Jul 2014 10:10:54 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 30.06.2014 um 16:09 hat Stefan Hajnoczi geschrieben:
> On Fri, Jun 27, 2014 at 10:17:16PM +0200, Benoît Canet wrote:
> I think this patch can be boiled down to 2 lines:
>
> if __name__ == '__main__':
> + if 'quorum' not in iotests.qemu_img('--help'):
> + iotests.notrun('not built with quorum support')
> iotests.main(supported_fmts=['qcow2', 'qed'])
>
> What do you think?
That would disable the whole test case 041, whereas Benoît's patch
only disables the quorum-related part. (The test case is really about
migration, not only quorum.)
Kevin
pgpYoChmJ0c0F.pgp
Description: PGP signature