Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

[Michael S. Tsirkin]

On Tue, Jul 01, 2014 at 03:29:03PM -0400, Ross Philipson wrote:
> On 07/01/2014 02:06 PM, Michael S. Tsirkin wrote:
> >On Tue, Jul 01, 2014 at 01:39:04PM -0400, Ross Philipson wrote:
> 
> [snip]
> 
> >
> >What class does your ISA bridge device have?
> 
> #define PCI_CLASS_BRIDGE_ISA             0x0601

Okay I guessed so. But IIRC Tiejun's suggesting giving it a different
class. So we don't know what the effect will be on various guests
without testing.


> >
> >>>
> >>>>Also I don't like the idea of tying Tiejun's patch series, that covers a
> >>>>very narrow use case, to something as important and general purpose as
> >>>>upgrading chipset.
> >>>
> >>>If it's true that implementing igd passthrough on top of q35 is much
> >>>cleaner architecturally, then I don't see why we should merge a stop-gap
> >>>solution that we'll need to then support indefinitely.
> >>>
> >>>We are talking about upstreaming functionality that xen already has, right?
> >>>So there's no time to market concern, whoever wants a solution today
> >>>has it.  Why not do it in the cleanest possible way?
> >>>
> >>
> >>
> >>--
> >>Ross Philipson
> >
> >-----
> >No virus found in this message.
> >Checked by AVG - www.avg.com
> >Version: 2014.0.4592 / Virus Database: 3986/7769 - Release Date: 06/30/14
> >
> 
> 
> -- 
> Ross Philipson