Re: [Qemu-devel] [PATCH_v2] ahci.c: mask unused flags when reading size PRDT DBC

[Stefan Hajnoczi]

On Tue, Jul 01, 2014 at 01:13:27PM +0200, address@hidden wrote:
> From: Reza Jelveh <address@hidden>
> 
> The data byte count(DBC) read from the description information is defined for
> bits 21:00. Bits 30:22 are reserved and bit 31 is the Interrupt on Completion
> (I) flag.
> 
> Completion interrupts are triggered after every transaction instead of on
> I-flag in QEMU. tbl_entry_size is a signed integer and improperly reading the
> DBC leads to a negative offset that causes sglist allocation to fail.
> 
> Signed-off-by: Reza Jelveh <address@hidden>
> ---
> This requires a custom ovmf image with sata controller for testing:
> 
> http://reza.jelveh.me/assets/OVMF.fd.bz2
> 
> Signed-off-by: Reza Jelveh <address@hidden>
> ---
>  hw/ide/ahci.c | 11 ++++++++---
>  hw/ide/ahci.h |  2 ++
>  2 files changed, 10 insertions(+), 3 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

pgpWnpiQPcWK6.pgp
Description: PGP signature