qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression
Date: Wed, 2 Jul 2014 10:44:16 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 02.07.2014 um 10:23 hat Paolo Bonzini geschrieben:
> Il 02/07/2014 08:55, Markus Armbruster ha scritto:
> >>> I think this fixes itself automatically if you use
> >>> rerror=stop/werror=stop on block jobs.  At least that was part of the
> >>> design, whether the implementation gets it right I cannot say without
> >>> looking at the code more carefully.
> >What if an underlying device doesn't support [rw]error=stop?  Not all
> >do...
> 
> Then the "fix" is to add support to the underlying device.  IDE,
> SCSI and virtio-blk (plus virtio-scsi via SCSI of course) are
> covered; the main one that's left out is SD.

Isn't block job rerror/werror completely independent from the guest
device using the same BDS? They are different users, so if we somehow
coupled them, that would be a design problem (which I think we were
careful enough to avoid).

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]