Re: [Qemu-devel] [RFC PATCH 18/22] Network packets record/replay

[Pavel Dovgaluk]

> > --- /dev/null
> > +++ b/net/net-replay.c
> > @@ -0,0 +1,56 @@
> > +#include "net/net.h"
> 
> Missing a copyright statement and declaration of license.  (We prefer
> GPLv2+ for new files, unless you have a strong reason otherwise, but
> whatever you pick must be compatible with GPLv2-only)
> 
> > +++ b/qapi-schema.json
> > @@ -2145,6 +2145,15 @@
> >      '*file': 'str' } }
> >
> >  ##
> > +# @NetdevReplayOptions
> > +#
> > +# Dump network traffic to the log in replay mode.
> > +#
> > +##
> 
> Missing a 'Since: 2.2' designation.  Is there any ability to control
> which file is used as the logging destination?

There is no ability to control packets loggings.
All incoming network traffic is written into the replay log,
which name is specified in the command line.

> 
> > +{ 'type': 'NetdevReplayOptions',
> > +  'data': { } }
> > +


Pavel Dovgaluk