[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 01/22] Makefiles
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC PATCH 01/22] Makefiles |
Date: |
Wed, 2 Jul 2014 12:14:30 +0100 |
On 2 July 2014 11:46, Kirill Batuzov <address@hidden> wrote:
> On Tue, 1 Jul 2014, Pavel Dovgaluk wrote:
>> +replay/replay.o replay/replay-events.o replay/replay-internal.o: CFLAGS+=
>> -Wno-unused-result
> Is this change really needed? I think it is better to avoid disabling
> compiler warnings without a good reason clearly stated in the commit
> message.
In this case these are new files and they're not some other
project's files we're importing, so we should just make them
comply with QEMU's usual warning levels from the start.
thanks
-- PMM