Re: [Qemu-devel] [PULL for-2.1 21/24] block: add QAPI command to allow live backing file change

[Kevin Wolf]

Am 02.07.2014 um 00:09 hat Eric Blake geschrieben:
> On 07/01/2014 02:48 AM, Stefan Hajnoczi wrote:
> > From: Jeff Cody <address@hidden>
> > 
> > This allows a user to make a live change to the backing file recorded in
> > an open image.
> > 
> 
> > +
> > +    /* final sanity check */
> > +    if (!bdrv_chain_contains(bs, image_bs)) {
> > +        error_setg(errp, "'%s' and image file are not in the same chain",
> > +                   device);
> > +        return;
> > +    }
> 
> Phooey - this is not bisectable, because bdrv_chain_contains was only
> introduced in 22/24.  But it's already been pulled, so nothing we can do
> about it now.

We should probably start using git-compile-check before doing pull
requests.  At least I haven't been doing this so far.

Kevin

pgpza9ZcXjwH6.pgp
Description: PGP signature