[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] bsd-user: Rename linux_binprm to bsd_binprm
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] bsd-user: Rename linux_binprm to bsd_binprm |
Date: |
Thu, 3 Jul 2014 14:23:29 +0100 |
On 20 June 2014 01:19, Sean Bruno <address@hidden> wrote:
> These too similar data structures will be diverging in future updates
> from my trees. Rename now.
>
> Signed-off-by: Sean Bruno <address@hidden>
> -int load_elf_binary(struct linux_binprm * bprm, struct target_pt_regs * regs,
> +int load_elf_binary(struct bsd_binprm * bprm, struct target_pt_regs * regs,
> struct image_info * info)
> -int load_elf_binary(struct linux_binprm * bprm, struct target_pt_regs * regs,
> +int load_elf_binary(struct bsd_binprm * bprm, struct target_pt_regs * regs,
> struct image_info * info);
> -int load_flt_binary(struct linux_binprm * bprm, struct target_pt_regs * regs,
> +int load_flt_binary(struct bsd_binprm * bprm, struct target_pt_regs * regs,
> struct image_info * info);
If you run this patch through checkpatch.pl you'll find that
it complains about the space following the "*" in these
function prototypes. You might as well fix that here since
you touch those lines anyway.
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 3/4] bsd-user: Rename linux_binprm to bsd_binprm,
Peter Maydell <=