[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 7/9] target-alpha: Fix cvttq vs large integers
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v2 7/9] target-alpha: Fix cvttq vs large integers |
Date: |
Thu, 3 Jul 2014 13:29:05 -0700 |
The range +- 2**63 - 2**64 was returning the wrong truncated
result. We also incorrectly signaled overflow for -2**63.
Reported-by: Al Viro <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target-alpha/fpu_helper.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/target-alpha/fpu_helper.c b/target-alpha/fpu_helper.c
index 19f3ebc..2b6c96b 100644
--- a/target-alpha/fpu_helper.c
+++ b/target-alpha/fpu_helper.c
@@ -721,12 +721,12 @@ static inline uint64_t inline_cvttq(CPUAlphaState *env,
uint64_t a,
if (shift >= 0) {
/* In this case the number is so large that we must shift
the fraction left. There is no rounding to do. */
- exc = float_flag_int_overflow | float_flag_inexact;
- if (shift < 63) {
+ if (shift < 64) {
ret = frac << shift;
- if ((ret >> shift) == frac) {
- exc = 0;
- }
+ }
+ /* Check for overflow. Note the special case of -0x1p63. */
+ if (shift >= 11 && a != 0xC3E0000000000000ull) {
+ exc = float_flag_int_overflow | float_flag_inexact;
}
} else {
uint64_t round;
--
1.9.3
- [Qemu-devel] [PATCH v2 0/9] target-alpha exception improvements, Richard Henderson, 2014/07/03
- [Qemu-devel] [PATCH v2 2/9] target-alpha: Set PC correctly for floating-point exceptions, Richard Henderson, 2014/07/03
- [Qemu-devel] [PATCH v2 1/9] target-alpha: Forget installed round mode after MT_FPCR, Richard Henderson, 2014/07/03
- [Qemu-devel] [PATCH v2 3/9] target-alpha: Store IOV exception in fp_status, Richard Henderson, 2014/07/03
- [Qemu-devel] [PATCH v2 8/9] target-alpha: Fix cvttq vs inf, Richard Henderson, 2014/07/03
- [Qemu-devel] [PATCH v2 4/9] target-alpha: Set fpcr_exc_status even for disabled exceptions, Richard Henderson, 2014/07/03
- [Qemu-devel] [PATCH v2 6/9] target-alpha: Raise IOV from CVTTQ, Richard Henderson, 2014/07/03
- [Qemu-devel] [PATCH v2 5/9] target-alpha: Set EXC_M_SWC for exceptions from /S insns, Richard Henderson, 2014/07/03
- [Qemu-devel] [PATCH v2 9/9] target-alpha: Fix integer overflow checking insns, Richard Henderson, 2014/07/03
- [Qemu-devel] [PATCH v2 7/9] target-alpha: Fix cvttq vs large integers,
Richard Henderson <=