qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] virtio-blk: dataplane: notify guest as a ba


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-blk: dataplane: notify guest as a batch
Date: Fri, 04 Jul 2014 17:48:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

Il 04/07/2014 16:52, Ming Lei ha scritto:
> What you can do is change notify_guest to something like
>
>     qemu_bh_schedule(req->dev->dataplane->notify_guest_bh);
>
> and do the actual notification in the bottom half.  This should ensure that
> multiple notifications are coalesced, but it may also introduce new
> aio_notify calls even with my patch (a BH scheduled from a BH currently does
> an aio_notify; this can be fixed).
I think we can do better than above because one aio IO completes lots of
requests, and we just need to notify guest for all these requests.

Exactly, there would be just one BH and thus just one notify.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]