Re: [Qemu-devel] [PATCH] compile QEMU with Xen support on ARM

[Peter Maydell]

On 4 July 2014 19:47, Stefano Stabellini
<address@hidden> wrote:
> Fixes to build QEMU with Xen support on ARM and ARM64. Most fixes are
> due to the fact that xen_pfn_t is 64-bit sized on arm32, while it is an
> unsigned long on x86_32.
> Although QEMU can be compiled with full emulation support, on ARM we
> only care about the PV backends.

Were you hoping to get this into 2.1 ?

> diff --git a/xen-mapcache.c b/xen-mapcache.c
> index eda914a..dde5ae8 100644
> --- a/xen-mapcache.c
> +++ b/xen-mapcache.c
> @@ -33,10 +33,10 @@
>  #  define DPRINTF(fmt, ...) do { } while (0)
>  #endif
>
> -#if defined(__i386__)
> +#if defined(__i386__) ||  defined(__arm__)
>  #  define MCACHE_BUCKET_SHIFT 16
>  #  define MCACHE_MAX_SIZE     (1UL<<31) /* 2GB Cap */
> -#elif defined(__x86_64__)
> +#elif defined(__x86_64__) || defined(__aarch64__)
>  #  define MCACHE_BUCKET_SHIFT 20
>  #  define MCACHE_MAX_SIZE     (1UL<<35) /* 32GB Cap */
>  #endif

This shouldn't be an architecture ifdef ladder, as I pointed out
last time around and you fixed in your previous v2. You want
an #if HOST_LONG_BITS == 32:

http://patchwork.ozlabs.org/patch/303028/

thanks
-- PMM