Re: [Qemu-devel] for-2.1 (was Re: [PATCH] ahci: map memory via device's address space instead of address_space_memory)

[Stefan Hajnoczi]

On Sun, Jul 06, 2014 at 09:15:38AM +0300, Michael S. Tsirkin wrote:
> On Thu, Jul 03, 2014 at 11:28:52AM +0300, Michael S. Tsirkin wrote:
> > On Thu, Jul 03, 2014 at 04:26:27PM +0800, Le Tan wrote:
> > > In map_page() in hw/ide/ahci.c, replace cpu_physical_memory_map() and
> > > cpu_physical_memory_unmap() with dma_memory_map() and dma_memory_unmap(),
> > > because ahci devices should not access memory directly but via their 
> > > address
> > > space. Add an AddressSpace parameter to map_page(). In order to call
> > > map_page(), we should pass the AHCIState.as as the AddressSpace argument.
> > > 
> > > Signed-off-by: Le Tan <address@hidden>
> > 
> > Makes sense
> > Reviewed-by: Michael S. Tsirkin <address@hidden>
> > 
> 
> Stefan, Kevin, you are going to pick this one?

Done.

Stefan

pgppBNwvKUpxz.pgp
Description: PGP signature