[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] bootindex dropped from -device virtio-blk, ? output, up
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] bootindex dropped from -device virtio-blk, ? output, upsets libvirt |
Date: |
Mon, 7 Jul 2014 11:06:50 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jul 04, 2014 at 02:47:41PM -0400, Cole Robinson wrote:
> qemu-2.1-rc0 upsets some of libvirt's qemu feature introspection, the example
> I hit is with bootindex support. qemu -device virtio-blk,? no longer lists the
> bootindex= property, so libvirt thinks that qemu doesn't support it, and fails
> to launch a VM with per-device boot order configuration.
>
> The qemu culprit is:
>
> commit caffdac363801cd2cf2bf01ad013a8c1e1e43800
> Author: Stefan Hajnoczi <address@hidden>
> Date: Wed Jun 18 17:58:33 2014 +0800
>
> virtio-blk: use aliases instead of duplicate qdev properties
>
> These alias properties aren't printed in qdev-monitor.c:qdev_device_help. In
> fact I'm not sure if aliases are even accessible in that function, since the
> they are only registered at instance init time, and I don't think any device
> has actually been initialized when qdev_device_help is called. That's my
> reading anyways.
>
> Thoughts?
I will send a fix.
Thanks,
Stefan
pgprrJTgnKyLw.pgp
Description: PGP signature