[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.1 0/4] block: Fix qiov sizes
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.1 0/4] block: Fix qiov sizes |
Date: |
Mon, 07 Jul 2014 09:05:05 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/04/2014 09:55 AM, Kevin Wolf wrote:
> Some callers use larger qiovs than nb_sectors for their read requests. This is
> bad because raw-posix uses nb_sectors to allocate a bounce buffer and then
> copies the whole iov over.
>
> This series fixes some more cases (mirroring was already fixed earlier this
> week) and adds assertions to catch any other offenders.
Is the intent to include this in 2.1?
>
> Kevin Wolf (4):
> block: Make qiov match the request size until EOF
> qcow2: Make qiov match request size until backing file EOF
> qed: Make qiov match request size until backing file EOF
> block: Assert qiov length matches request length
>
> block.c | 13 ++++++++++++-
> block/qcow2.c | 11 ++++++++++-
> block/qed.c | 26 +++++++++++++++++++++++---
> block/qed.h | 1 +
> block/raw-posix.c | 15 +++++++++++----
> 5 files changed, 57 insertions(+), 9 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature