[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 10/28] ide: remove wrong setting of BM_STATUS_INT
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH 10/28] ide: remove wrong setting of BM_STATUS_INT |
Date: |
Mon, 7 Jul 2014 14:17:51 -0400 |
From: Paolo Bonzini <address@hidden>
Similar to the case removed in commit 69c38b8 (ide/core: Remove explicit
setting of BM_STATUS_INT, 2011-05-19), the only remaining use of
add_status(..., BM_STATUS_INT) is for short PRDs. The flag should
not be raised in this case.
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
hw/ide/ahci.c | 4 ----
hw/ide/atapi.c | 1 -
2 files changed, 5 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index adbac3d..14677ec 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1107,10 +1107,6 @@ static int ahci_dma_add_status(IDEDMA *dma, int status)
AHCIDevice *ad = DO_UPCAST(AHCIDevice, dma, dma);
DPRINTF(ad->port_no, "set status: %x\n", status);
- if (status & BM_STATUS_INT) {
- ahci_trigger_irq(ad->hba, ad, PORT_IRQ_STAT_DSS);
- }
-
return 0;
}
diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index d13395e..46ed3f5 100644
--- a/hw/ide/atapi.c
+++ b/hw/ide/atapi.c
@@ -355,7 +355,6 @@ static void ide_atapi_cmd_read_dma_cb(void *opaque, int ret)
eot:
bdrv_acct_done(s->bs, &s->acct);
- s->bus->dma->ops->add_status(s->bus->dma, BM_STATUS_INT);
ide_set_inactive(s);
}
--
1.9.3
- [Qemu-devel] [PATCH 08/28] ide: simplify start_transfer callbacks, (continued)
- [Qemu-devel] [PATCH 08/28] ide: simplify start_transfer callbacks, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 14/28] ahci: remove duplicate PORT_IRQ_* constants, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 09/28] ide: wrap start_dma callback, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 13/28] ide: move retry constants out of BM_STATUS_* namespace, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 16/28] ide: make all commands go through cmd_done, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 10/28] ide: remove wrong setting of BM_STATUS_INT,
John Snow <=
- [Qemu-devel] [PATCH 15/28] ide: stop PIO transfer on errors, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 17/28] ahci: construct PIO Setup FIS for PIO commands, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 18/28] q35: Enable the ioapic device to be seen by qtest., John Snow, 2014/07/07
- [Qemu-devel] [PATCH 21/28] libqtest: Correct small memory leak., John Snow, 2014/07/07