[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu |
Date: |
Mon, 07 Jul 2014 12:14:07 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote:
> +
> + /* GPR Register */
> + target_ulong gpr_a[16];
> + target_ulong gpr_d[16];
> +};
> +
> +typedef struct tricore_def_t tricore_def_t;
> +
> +typedef struct CPUTRICOREState CPUTRICOREState;
> +struct CPUTRICOREState {
> + TCState active_tc;
You'll get better code generation if you put the gprs first. Some hosts will
need a 2 insn sequence for large offsets, and even x86 will have a code size
benefit from having offsets < 128.
Is there any real need for the active_tc thing, or did you just copy MIPS?
Personally, I dislike it, and unless you're planning on using structure
assignment to copy data around during certain context switches, please drop it.
r~
- Re: [Qemu-devel] [PATCH 15/15] target-tricore: Add instructions of SR opcode format, (continued)
- [Qemu-devel] [PATCH 04/15] target-tricore: Add initialization for translation, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 11/15] target-tricore: Add instructions of SBC and SBRN opcode format, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 12/15] target-tricore: Add instructions of SBR opcode format, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu, Bastian Koppelmann, 2014/07/07
- Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu, Richard Henderson, 2014/07/07
- [Qemu-devel] [PATCH 08/15] target-tricore: Add instructions of SSR opcode format, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 10/15] target-tricore: Add instructions of SB opcode format, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 14/15] target-tricore: Add instructions of SLR, SSRO and SRO opcode format, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 03/15] target-tricore: Add softmmu support, Bastian Koppelmann, 2014/07/07
- [Qemu-devel] [PATCH 09/15] target-tricore: Add instructions of SRRS and SLRO opcode format., Bastian Koppelmann, 2014/07/07