qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 126/156] block/qapi: Plug memory leak in dump_qobjec


From: Michael Roth
Subject: [Qemu-devel] [PATCH 126/156] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR
Date: Tue, 8 Jul 2014 12:18:37 -0500

From: Markus Armbruster <address@hidden>

Introduced in commit a8d8ecb.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Benoit Canet <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
(cherry picked from commit f25391c2a6ef1674384204265429520ea50e82bc)
Signed-off-by: Michael Roth <address@hidden>
---
 block/qapi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/qapi.c b/block/qapi.c
index 5880b3e..e9007c9 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -471,6 +471,7 @@ static void dump_qobject(fprintf_function func_fprintf, 
void *f,
         case QTYPE_QERROR: {
             QString *value = qerror_human((QError *)obj);
             func_fprintf(f, "%s", qstring_get_str(value));
+            QDECREF(value);
             break;
         }
         case QTYPE_NONE:
-- 
1.9.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]