Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load

[Amit Shah]

On (Wed) 09 Jul 2014 [11:28:27], Peter Maydell wrote:
> On 9 July 2014 05:25, Amit Shah <address@hidden> wrote:
> > (CC'ing Peter Maydell for his thoughts)
> >
> > On (Tue) 08 Jul 2014 [22:55:42], Peter Lieven wrote:
> >> Hi Juan,
> >>
> >> Am 25.06.2014 um 13:55 schrieb Juan Quintela <address@hidden>:
> >>
> >> > Peter Lieven <address@hidden> wrote:
> >> >> this patch extends commit db80fac by not only checking
> >> >> for unknown flags, but also filtering out unknown flag
> >> >> combinations.
> >> >>
> >> >> Suggested-by: Eric Blake <address@hidden>
> >> >> Signed-off-by: Peter Lieven <address@hidden>
> >> >
> >> > Reviewed-by: Juan Quintela <address@hidden>
> >> >
> >> > Will be on next pull request, thanks.
> >> >
> >>
> >> Have you forgotten to pull this one? It might be too late for 2.1 though.
> >
> > Juan is away for a couple of weeks.  This looks like a good fix to
> > pull in for 2.1, though.  Peter, do you agree?  Can you pick this up
> > if so?
> 
> What's the bug it's fixing? I had a look at the commit message,
> but that suggests it's just tightening up sanity checking, not
> fixing an actual issue... Maybe you can clarify.

Right, it improves correctness: after this patch, we ensure a rogue or
corrupt migration stream cannot cause problems on the dest.

                Amit