qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 06/14] block/mirror: Improve progress report


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v9 06/14] block/mirror: Improve progress report
Date: Wed, 09 Jul 2014 23:24:19 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

Il 07/07/2014 21:13, Eric Blake ha scritto:
On 07/05/2014 11:47 AM, Max Reitz wrote:
Instead of taking the total length of the block device as the block
job's length, use the number of dirty sectors. The progress is now the
number of sectors mirrored to the target block device. Note that this
may result in the job's length increasing during operation, which is
however in fact desirable.

Signed-off-by: Max Reitz <address@hidden>
---
 block/mirror.c | 34 ++++++++++++++++++++++------------
 1 file changed, 22 insertions(+), 12 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

This is an API change... IIUC the length can become bigger than the underlying device's size. Eric, how would libvirt expose this to clients and what are the chances that they get confused?

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]