[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.1?] scripts: qapi-event.py: support vendor
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.1?] scripts: qapi-event.py: support vendor extension |
Date: |
Wed, 09 Jul 2014 09:43:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/08/2014 12:17 PM, Luiz Capitulino wrote:
> The event code generator barfs when it sees a dot in an event
> argument, this makes it impossible to support vendor extensions
> in event arguments as they always contain dots. Fix this by
> replacing dots by hyphens in the generated code.
>
> PS: Event names and QMP command arguments may suffer from the
> same issue, but I'm not checking/fixing them today.
>
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
> scripts/qapi-event.py | 8 ++++----
> scripts/qapi.py | 4 ++++
> 2 files changed, 8 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
This is borderline on whether it is a bug fix worth applying in 2.1 - it
is fixing something that is new to this release (event-as-qapi) and
which affects downstream vendors; but at the same time, it is something
which cannot be triggered _except_ by downstream vendors, which are
perfectly capable of applying this patch even if it misses 2.1. I'll
leave it up to you.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension, Luiz Capitulino, 2014/07/10
- Re: [Qemu-devel] [PATCH for-2.1?] scripts: qapi-event.py: support vendor extension,
Eric Blake <=
- Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension, Markus Armbruster, 2014/07/10
- Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension, Eric Blake, 2014/07/10
- Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension, Luiz Capitulino, 2014/07/10
- Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension, Markus Armbruster, 2014/07/11
- Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension, Eric Blake, 2014/07/11
- Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension, Markus Armbruster, 2014/07/11
- Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension, Luiz Capitulino, 2014/07/11
- Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension, Eric Blake, 2014/07/11
- Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension, Luiz Capitulino, 2014/07/14