qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] SIOCGIFINDEX: fix typo


From: Joakim Tjernlund
Subject: Re: [Qemu-devel] [PATCH] SIOCGIFINDEX: fix typo
Date: Fri, 11 Jul 2014 03:45:27 +0200

Joakim Tjernlund <address@hidden> wrote on 2014/07/11 
03:02:02:

> 
> Wrong type was used in ioctl definition.
> 
> Signed-off-by: Joakim Tjernlund <address@hidden>
> ---
> 
> However, this does not fix my dhcp problem:
> 
> jocke-ppc ~ # busybox udhcpc -v
> Adapter index 24
> MAC fe:22:44:22:55:77
> udhcpc (v1.21.0) started
> Executing /usr/share/udhcpc/default.script deconfig
> Setting IP address 0.0.0.0 on eth0
> Entering listen mode: raw
> Opening raw socket on ifindex 24
> Got raw socket fd
> udhcpc: bind: No such device
> jocke-ppc ~ # cat /sys/class/net/eth0/ifindex 
> 24

I may have found the error, in  target_to_host_sockaddr() we only have
sa_family = tswap16(target_saddr->sa_family); w.r.t endian.
However a AF_INET also have:
    stSockAddr.sin_port = htons(1100);
    stSockAddr.sin_addr.s_addr = htonl(INADDR_ANY);
There is no endian conversion for these(there may be other cases too?)

 Jocke



reply via email to

[Prev in Thread] Current Thread [Next in Thread]