qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] scsi-bus: fix to allow some special SCSI comman


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] scsi-bus: fix to allow some special SCSI commands
Date: Fri, 11 Jul 2014 11:02:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

Il 11/07/2014 10:53, TAMUKI Shoichi ha scritto:
@@ -563,7 +565,8 @@ SCSIRequest *scsi_req_new(SCSIDevice *d, uint32_t tag, 
uint32_t lun,
     SCSIRequest *req;
     SCSICommand cmd;

-    if (scsi_req_parse(&cmd, d, buf) != 0) {
+    if (scsi_req_parse(&cmd, d, buf,
+            ((VirtIOSCSIReq *) hba_private)->dev->parent_obj.cdb_size) != 0) {
         trace_scsi_req_parse_bad(d->id, lun, tag, buf[0]);
         req = scsi_req_alloc(&reqops_invalid_opcode, d, tag, lun, hba_private);
     } else {

This function is not called only for virtio-scsi. You need to add a new argument to scsi_req_new, and modify all invocations in hw/scsi.

Thanks,

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]