[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 1/1] spice: auth fixes
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PULL 1/1] spice: auth fixes |
|
Date: |
Fri, 11 Jul 2014 13:18:04 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
> Set auth to sasl when sasl is enabled, this makes "info spice" correctly
> display sasl auth.
Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it?
If yes, I'd recommend to note this in the commit message.
> Also throw an error in case someone tries to set
> a spice password via monitor without auth mode being "spice".
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
Since the patch looks fine to me:
Reviewed-by: Markus Armbruster <address@hidden>