Re: [Qemu-devel] [PATCH 4/4] ppc: remove excessive logging

[Joakim Tjernlund]

Peter Maydell <address@hidden> wrote on 2014/07/11 19:14:25:

> 
> On 11 July 2014 16:18, Joakim Tjernlund <address@hidden> 
wrote:
> > ppc logs every type of Invalid instruction. This generates a lot
> > of garbage on console when sshd/ssh_keygen executes as
> > they try various insn to optimize its performance.
> > The invalid operation log is still there so an unknown insn
> > will still be logged.
> >
> > Signed-off-by: Joakim Tjernlund <address@hidden>
> > ---
> >  linux-user/main.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/linux-user/main.c b/linux-user/main.c
> > index b453a39..71a33c7 100644
> > --- a/linux-user/main.c
> > +++ b/linux-user/main.c
> > @@ -1698,7 +1698,6 @@ void cpu_loop(CPUPPCState *env)
> >                  }
> >                  break;
> >              case POWERPC_EXCP_INVAL:
> > -                EXCP_DUMP(env, "Invalid instruction\n");
> >                  info.si_signo = TARGET_SIGILL;
> >                  info.si_errno = 0;
> >                  switch (env->error_code & 0xF) {
> 
> Rather than just deleting this EXCP_DUMP, I would suggest
> changing the EXCP_DUMP macro so  it only does anything
> if the user has passed the "-d int" debug logging flag:

I don't think ppc wants that. They want unconditionally
debug on to get relevant bug reports. This one is getting in the
way of normal operations so I think it should be deleted.

 Jocke