qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] vhost-user fixes


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 0/3] vhost-user fixes
Date: Fri, 11 Jul 2014 22:57:24 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

Il 08/07/2014 16:05, Nikolay Nikolaev ha scritto:
The latest vhost-user changes changed the VHOST_SET_MEM_TABLE handling.
Now the memory regions are mapped from dev->mem. The BIOS is registered
at address 0xfffc0000 which is out of memory boundaries for guests with
less than 4G RAM. Calling qemu_get_ram_fd with this address causes abort()
in qemu_get_ram_block with "Bad ram offset".

To prevent this situation we introduce a new function to check if the address
maps to any RAMBlock - qemu_is_ram_block. This is used in VHOST_SET_MEM_TABLE
handling to revent the aborting call to qemu_get_ram_fd.

The related vhost-user qtest is also updated to reflect the changes in
vhost-user message structures.

Patch 3 seems okay. Patches 1 and 2 are not but the actual fix is similarly simple.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]