qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging


From: Alexander Graf
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging
Date: Sat, 12 Jul 2014 02:39:21 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0


On 11.07.14 20:22, Peter Maydell wrote:
On 11 July 2014 19:15, Joakim Tjernlund <address@hidden> wrote:
Peter Maydell <address@hidden> wrote on 2014/07/11 19:14:25:
On 11 July 2014 16:18, Joakim Tjernlund <address@hidden>
wrote:
ppc logs every type of Invalid instruction. This generates a lot
Rather than just deleting this EXCP_DUMP, I would suggest
changing the EXCP_DUMP macro so  it only does anything
if the user has passed the "-d int" debug logging flag:
I don't think ppc wants that. They want unconditionally
debug on to get relevant bug reports. This one is getting in the
way of normal operations so I think it should be deleted.
If the PPC maintainers want that behaviour then they need
to defend it. No other architecture's linux-user code spews
junk to stderr for exceptions, and PPC shouldn't either.
The debug log switches are exactly for allowing us to
say "please turn on debug logging" when bugs are reported,
and those are what we should use.

I agree - and it's how we behave in system emulation mode already :).

What do the other platforms do on illegal instructions during user mode? Any way we can get consistency across the board?


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]