Re: [Qemu-devel] [PATCH] scsi: Report error when lun number is in use

[Fam Zheng]

On Tue, 06/10 14:55, Fam Zheng wrote:
> In the case that the lun number is taken by another scsi device, don't
> release the existing device siliently, but report an error to user.
> 
> Signed-off-by: Fam Zheng <address@hidden>

Do we want this in 2.1?

Fam

> ---
>  hw/scsi/scsi-bus.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
> index 06399fa..d219da3 100644
> --- a/hw/scsi/scsi-bus.c
> +++ b/hw/scsi/scsi-bus.c
> @@ -177,7 +177,8 @@ static int scsi_qdev_init(DeviceState *qdev)
>          d = scsi_device_find(bus, dev->channel, dev->id, dev->lun);
>          assert(d);
>          if (d->lun == dev->lun && dev != d) {
> -            object_unparent(OBJECT(d));
> +            error_report("lun already used by '%s'", d->qdev.id);
> +            goto err;
>          }
>      }
>  
> -- 
> 2.0.0
> 
>