Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/2] spapr: Enable huge pages again

[Alexander Graf]

On 14.07.14 19:24, Alexander Graf wrote:
> On 14.07.14 15:30, Paolo Bonzini wrote:
> > Il 14/07/2014 15:13, Alexey Kardashevskiy ha scritto:
> > > On 07/11/2014 01:03 AM, Alexey Kardashevskiy wrote:
> > > > This does small RMA allocation rework and enables huge pages.
> > > >
> > > > Please comment, especially commit logs. Thanks!
> > > >
> > > > Changes:
> > > > v3:
> > > > * split to 2 patches, one mechanical
> > > > * tested on PPC970
> > > >
> > > > v2:
> > > > * moved RMA memory region out of KVM code
> > >
> > >
> > > This is 2.2 stuff, right? :)
> >
> > For me it would be okay for 2.1, but Alex may disagree.
>
> No, I agree. Missing huge page support is a regression over 2.0.
>
> Thanks, applied to for-2.1.

ppc-next of course.

I had to add this patch on top to make compilation work on non-PPC hosts:

diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h
index ac16a47..d9516e7 100644
--- a/target-ppc/kvm_ppc.h
+++ b/target-ppc/kvm_ppc.h
@@ -134,7 +134,7 @@ static inline int 
kvmppc_booke_watchdog_enable(PowerPCCPU *cpu)
 }

 #ifndef CONFIG_USER_ONLY
-static inline off_t kvmppc_alloc_rma(const char *name, MemoryRegion 
*sysmem)
+static inline off_t kvmppc_alloc_rma(void **rma)
 {
     return 0;
 }


Alex