Re: [Qemu-devel] [PATCH v3 2/2] qapi: add read-pattern support for quorum

[Liu Yuan]

On Tue, Jul 15, 2014 at 06:22:14AM -0600, Eric Blake wrote:
> On 07/15/2014 12:34 AM, Liu Yuan wrote:
> > Cc: Eric Blake <address@hidden>
> > Signed-off-by: Liu Yuan <address@hidden>
> > ---
> >  qapi/block-core.json | 19 ++++++++++++++++++-
> >  1 file changed, 18 insertions(+), 1 deletion(-)
> > 
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index e378653..22491bc 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -1384,6 +1384,18 @@
> >              'raw': 'BlockdevRef' } }
> >  
> >  ##
> > +# @QuorumReadPattern
> > +# An enumeration of quorum read pattern.
> 
> s/pattern/patterns/
> 
> > +#
> > +# @quorum: read all the children and do a quorum vote on reads
> > +#
> > +# @fifo: read a single child and try next child in FIFO order if read 
> > fails.
> 
> Inconsistent on whether you are ending a line with '.'.  I'm not quite
> sure if this reads well; maybe:
> 
> @fifo: read only from the first child that has not failed
> 
> I also wonder if 'single' might be a better name than 'fifo', especially
> if we later add a 'round-robin' for read load balancing.

Both fifo and round-robin in our context indicate a single read.

but either one looks okay to me. We need to reach agreement on the name before I
send the next version, single or fifo or any other suggested, Benoit, Kevin,
Stefan?

Thanks
Yuan