Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

[Peter Maydell]

On 16 July 2014 10:17, Alex Bennée <address@hidden> wrote:
> On aarch64 we do:
>
> #define unsupported_encoding(s, insn)                                    \
>     do {                                                                 \
>         qemu_log_mask(LOG_UNIMP,                                         \
>                       "%s:%d: unsupported instruction encoding 0x%08x "  \
>                       "at pc=%016" PRIx64 "\n",                          \
>                       __FILE__, __LINE__, insn, s->pc - 4);              \
>         unallocated_encoding(s);                                         \
>     } while (0);
>
> So we signal it's unimplemented before falling through to the signal
> generating code.

Yes, but that macro is only for instructions which exist but which
QEMU doesn't implement, not for instructions which exist and
which we do have an implementation of but which we generate an
exception for because they aren't present on this particular CPU.
That's a separate issue from whether you might want to optionally
log every SIGILL a process generates.

thanks
-- PMM