[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc val
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation" |
Date: |
Fri, 18 Jul 2014 17:15:41 +0530 |
On (Fri) 18 Jul 2014 [13:36:15], Alexander Graf wrote:
>
> On 18.07.14 13:31, Amit Shah wrote:
> >On (Fri) 18 Jul 2014 [11:04:24], Paolo Bonzini wrote:
> >>This reverts commit 9b1786829aefb83f37a8f3135e3ea91c56001b56.
> >>
> >>Cc: address@hidden
> >>Cc: address@hidden
> >>Cc: address@hidden
> >>Signed-off-by: Paolo Bonzini <address@hidden>
> >Please include some information on why this is being reverted. Helps
> >people browsing the tree later.
>
> Yeah, I'm also not convinced it's a great idea to trade one known bug with
> another known bug.
I'm not opposed to the revert, though. We don't yet have a fix for
the issue caused by the original patch, and Paolo is being
conservative in keeping the older bug around for 2.1, rather than
trading it for unknown bugs at this stage.
The investigation for the bug is proceeding, though, and we may get a
fix soon. If it turns out to be well-contained, we could also look at
backporting all the fixes to -stable, if it helps.
Amit
- [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18, Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 6/6] Revert "kvmclock: Ensure time in migration never goes backward", Paolo Bonzini, 2014/07/18
- [Qemu-devel] [PULL 2/6] qtest: new test for wdt_ib700, Paolo Bonzini, 2014/07/18
- Re: [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18, Peter Maydell, 2014/07/18