Re: [Qemu-devel] [PATCH v4 5/8] BitmapLog: cancel mechanism for an already running dump bitmap process

[Eric Blake]

On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote:
> Signed-off-by: Sanidhya Kashyap <address@hidden>
> ---
>  hmp-commands.hx  | 14 ++++++++++++++
>  hmp.c            |  5 +++++
>  hmp.h            |  1 +
>  qapi-schema.json |  8 ++++++++
>  qmp-commands.hx  | 21 +++++++++++++++++++++
>  savevm.c         | 19 +++++++++++++++++++
>  6 files changed, 68 insertions(+)

So here you provide HMP and QMP in one patch (fine); but earlier you
separated them between 3/8 and 4/8.  Might be nice to be consistent in
the series.

> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 575df78..61eca66 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1804,6 +1804,20 @@ STEXI
>  dumps the writable working set of a VM's memory to a file
>  ETEXI
>  
> +     {
> +     .name       = "ldbc|log-dirty-bitmap-cancel",

HMP commands still use _ in their names; it's only QMP where we prefer dash.

> +++ b/qapi-schema.json
> @@ -3503,3 +3503,11 @@
>    'data'    : { 'filename'      : 'str',
>                  '*epochs'       : 'int',
>                  '*frequency'    : 'int' } }
> +##
> +# @log-dirty-bitmap-cancel
> +#
> +# cancel the dirty bitmap logging process
> +#
> +# Since 2.2
> +##
> +{ 'command': 'log-dirty-bitmap-cancel' }

Correctly named with dash here...

> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 200f57e..69d4a07 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -3785,3 +3785,24 @@ Examples:
>  Note: The epochs, frequency and readable are optional. epochs default
>  value is 3 while that of frequency is 10.
>  EQMP
> +
> +     {
> +        .name       = "log-dirty-bitmap-cancel",
> +        .args_type  = "",
> +        .mhandler.cmd_new = qmp_marshal_input_log_dirty_bitmap_cancel,
> +    },
> +
> +SQMP
> +log_bitmap_cancel

...but completely wrong name here.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature