[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 4/5] VMState test: set the frequency of t
From: |
Sanidhya Kashyap |
Subject: |
Re: [Qemu-devel] [RFC PATCH v1 4/5] VMState test: set the frequency of the vmstate testing process |
Date: |
Sat, 19 Jul 2014 00:29:22 +0530 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
> This feels like a write-only command. How do I query what it is
> currently set to?
>
> I'm also afraid that we aren't learning our lessons from migrate.
> Adding one new command per new tunable does not scale very well in
> the number of commands that need to be maintained or that have to
> be wired up in management software; better is adding a single
> command pair for set/get that can be easily introspected (to see
> when new tunables are added), by taking an array of tunables where
> each tunable is a struct containing name, type, and value
> information. Something like:
>
> {"execute":"test-vmstates-set-tuning", "arguments":{ "list":[ {
> "name":"sinterval", "type":"int", "value":100 }, { "name":"other",
> "type":"...", "value":... } ]}} {"return": {}}
>
> and a counterpart:
>
> {"execute":"test-vmstates-get-tuning" } {"return": [ {
> "name":"sinterval", "type":"int", "value":100 }, { "name":"other",
> "type":"...", "value":... } ]}
>
>
Well, I have some issues about the implementation of the list which is
associated with the set-tuning one. Any patch illustrating the above
example which includes list will help me a lot.
Thanks.
- --
- -----
Sanidhya Kashyap
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTyW6KAAoJEFt9RLmoahlnFQkIAJL6z0jo72gEc67ISr6pNxyH
sxFbT67LNHhliWlVvohOPqC4e8hGOfXJb5gmPr2UFZUbVNKLrGc1Mh8t5OeRPR2y
3twA+3uUvpuJhc6F+KH4Z125Qirj7Uom9/PCtOYD9QMIAOEkD9SzD1S3ZpWL6I2r
+l0s2xkFScG9eHyqe6pJlKRIORm9FnKVhYS18bzXz1WWh1mJTjF6qXNfbCS3OyqT
9rk1ZcYyYei/JNoclgC7Mvxy5QpQxrhhjwDFK0G3vFaPte+K+CYpGHL8a5s0sPFb
OOZ29X+5Zz4wOx9btf0+LovqSwrLueHCdF/l65+jSNPRRsvB4MslQva/Rybs4Kg=
=DpKh
-----END PGP SIGNATURE-----
- [Qemu-devel] [RFC PATCH v1 0/5] VMState testing, Sanidhya Kashyap, 2014/07/07
- [Qemu-devel] [RFC PATCH v1 1/5] QEMUSizedBuffer/QEMUFile, Sanidhya Kashyap, 2014/07/07
- [Qemu-devel] [RFC PATCH v1 2/5] VMState test: basic vmstate testing mechanism, Sanidhya Kashyap, 2014/07/07
- [Qemu-devel] [RFC PATCH v1 3/5] VMState test: hmp interface for vmstate testing, Sanidhya Kashyap, 2014/07/07
- [Qemu-devel] [RFC PATCH v1 4/5] VMState test: set the frequency of the vmstate testing process, Sanidhya Kashyap, 2014/07/07
- [Qemu-devel] [RFC PATCH v1 5/5] VMState test: cancel mechanism for an already running vmstate testing process, Sanidhya Kashyap, 2014/07/07